Skip to content

Fix issue for Oracle 11.2 where the local collection is used SQL #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 1 commit into from
Jun 20, 2019
Merged

Fix issue for Oracle 11.2 where the local collection is used SQL #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/expectations/data_values/ut_compound_data_helper.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,12 +724,13 @@ create or replace package body ut_compound_data_helper is
return l_diffs.count;
end;

function get_json_diffs_type(a_diffs_all tt_json_diff_tab) return tt_json_diff_type_tab is
function get_json_diffs_type(a_diff_id raw) return tt_json_diff_type_tab is
l_diffs_summary tt_json_diff_type_tab := tt_json_diff_type_tab();
begin
select d.difference_type,count(1)
bulk collect into l_diffs_summary
from table(a_diffs_all) d
from ut_json_data_diff_tmp d
where diff_id = a_diff_id
group by d.difference_type;

return l_diffs_summary;
Expand Down
2 changes: 1 addition & 1 deletion source/expectations/data_values/ut_compound_data_helper.pks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ create or replace package ut_compound_data_helper authid definer is
function get_json_diffs_tmp(a_diff_id raw) return tt_json_diff_tab;


function get_json_diffs_type(a_diffs_all tt_json_diff_tab) return tt_json_diff_type_tab;
function get_json_diffs_type(a_diff_id raw) return tt_json_diff_type_tab;

end;
/
6 changes: 3 additions & 3 deletions source/expectations/data_values/ut_data_value_json.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ create or replace type body ut_data_value_json as
l_diffs ut_compound_data_helper.tt_json_diff_tab;
l_message varchar2(32767);

function get_diff_by_type(a_diff ut_compound_data_helper.tt_json_diff_tab) return clob is
l_diff_summary ut_compound_data_helper.tt_json_diff_type_tab := ut_compound_data_helper.get_json_diffs_type(a_diff);
function get_diff_by_type(a_diff_id raw) return clob is
l_diff_summary ut_compound_data_helper.tt_json_diff_type_tab := ut_compound_data_helper.get_json_diffs_type(a_diff_id);
l_message_list ut_varchar2_list := ut_varchar2_list();
begin
for i in 1..l_diff_summary.count loop
Expand Down Expand Up @@ -103,7 +103,7 @@ create or replace type body ut_data_value_json as
l_message := ' '||l_diffs.count|| ' differences found' ||
case when l_diffs.count > c_max_rows then ', showing first '|| c_max_rows else null end||chr(10);
ut_utils.append_to_clob( l_result, l_message );
l_message := get_diff_by_type(l_diffs)||chr(10);
l_message := get_diff_by_type(l_diff_id)||chr(10);
ut_utils.append_to_clob( l_result, l_message );

for i in 1 .. least( c_max_rows, l_diffs.count ) loop
Expand Down