Skip to content

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented Jun 12, 2019

Resolves #934

@jgebal jgebal added the bugfix label Jun 12, 2019
@jgebal jgebal added this to the v3.1.7 milestone Jun 12, 2019
Copy link
Member

@PhilippSalvisberg PhilippSalvisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing it.

@PhilippSalvisberg
Copy link
Member

Good idea to change names of the output buffer tables. This ensures that code that uses this tables will fail.

Copy link
Member

@PhilippSalvisberg PhilippSalvisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed it locally and run all tests sucessfully.
Additionally I used it from the SQL Developer extension. Worked there as well.
Looks good. Thanks a lot!

@PhilippSalvisberg PhilippSalvisberg merged commit bd14e43 into develop Jun 12, 2019
@jgebal jgebal deleted the feature/fix_output_buffer_cleanup branch June 17, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup_buffer fails if realtime_reporter is used

3 participants