Adding suite check API & performance improvements #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jgebal merged 34 commits into develop from feature/suite_query_api

Nov 18, 2018

Member

jgebal commented Nov 17, 2018 •

edited

Loading

added new APIs in ut_runner
- get_suites_info - resolves Add ability to retrieve information abut test suites #785
- is_test - resolves Add ability to check if procedure is a test #788
- is_suite - resolves Ability to check if package is a test suite #787
- has_suites - resolves Add ability to check if schema has suites #786

Added suite level cache as a complementary cache on top of annotations cache.
Improved performance of suite-builder by using IN OUT NOCOPY and avoiding large data variable copying/assignments.
Minimized the amount of data scanned after package compilation.

We now join to all_objects only when executing user doesn't have execute any and is not owner of test packages.

Resolves #778

Reworked output buffer and reporters for performance (we now do bulk inserts into buffer where applicable) - resolves #777

jgebal added 24 commits

November 4, 2018 01:36


          Interim commit with lots of dirty code - got to a place where I get t…

e41d6f9

…he infamous ORA-00600

`ORA-00600: internal error code, arguments: [pfrobj.c: invalid RTTI for Object], [], [], [], [], [], [], [], [], [], [], []``


          Added suite_cache.

f475b7c

Refactored lots of code for suite parsing/building.
(Acceptance) tests need rework due to changes in test execution ordering.


          Interim commit - performance check on Travis.

4dc48e6


          Interim commit some fixes to old tests, examples and code itself.

1611e09

One problem to be solved. Oracle nested tables are **unordered!** and we need an ordered list of before/after items that contain CLOB column, so cannot be varray.


          Resolved issue with sorting of nested-tables.

15163a8

Added `seq_no`, numbering before storage and sorting after retrieval.


          Fixing re-enabled test.

1b14bb5


          Adding missing items to uninstall.

3bc8da5


          Small improvements and cleanup.

8911f97


          Removing duplicate with block.

a1f6b34


          Adding cache cleanup and "intelligent" join to all_source, only when …

59f7738

…needed.


          Resolving some sonar violations.

cb9cf97


          Moving away from full outer join.

Added static schema name rather than bind variable.


          Reorganizing code a bit.

b3e98be


          Output buffer&reporters performance improvements

64dfb41


          Increased fetch size for coverage sources tmp seeding.

9ea805b


          Small refactoring.

248bf8c

Adding new function to return list of suites and tests.


          Further optimizations to suite parsing.

8fc2ea6

Changed functions to procedures to avoid copying of large memmory segments.


          Disabled PLSQL_OPTIMIZE_LEVEL=0 for testing

3543e3d


          Fixed formal parameter names

23c0557


          Revert "Disabled PLSQL_OPTIMIZE_LEVEL=0 for testing"

f7f6811

This reverts commit 3543e3d


          Refactored procedure get_unit_test_info to return more relevant inf…

d002d18

…ormation based on info suite cache.

Suite cache is refreshed when calling procedure (as needed).


          Renamed get_unit_test_info to get_suites_info - the latter one wa…

e1f1eec

…s not used uin prior versions.

Added functions `is_test`, `is_suite`, `has_suite` to perform checks for test/suite existance at prcedure, package, schema level.


          Improved automation of refresh_sources.sh

d8d251f

The script will now automatically copy `*.jar` files into `/utPLSQL-cli/lib` directory.


          Fixing failing test.

eb3df21

jgebal added this to the v3.1.3 milestone

jgebal requested review from Pazus, PhilippSalvisberg and lwasylow

November 17, 2018 00:13


          Added control over rollback behavior in ut_runner.run

d211348

Fixed failing test.

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6

Including the following issue(s) which could not be reported in line:

Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6

Including the following issue(s) which could not be reported in line:

Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6

Including the following issue(s) which could not be reported in line:

Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 6

Including the following issue(s) which could not be reported in line:

Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: The procedure "run" should be refactored to take at most 10 parameters instead of 11 as currently. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

jgebal added 2 commits

November 17, 2018 21:11


          Reverting rollback changes - they should go as a separate PR.

f342195


          Added documentation for new functionality.

eeae79b

Added default value for owner, when calling `get_suites_info`

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5

Including the following issue(s) which could not be reported in line:

Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5

Including the following issue(s) which could not be reported in line:

Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5

Including the following issue(s) which could not be reported in line:

Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud

utplsql-travis reviewed

View reviewed changes

utplsql-travis left a comment

SonarQube analysis found issues:
Bugs: 0
Vulnerabilities: 0
Code Smells: 5

Including the following issue(s) which could not be reported in line:

Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)
Code Smell: Complete the task associated to this "TODO" comment. (more)

See all issues in SonarCloud


          Removed unused code.

74ec9a1

Added additional tests to:
- cover functionality of reporting warnings on transaction invalidation with sub-suites.
- cover functionality of failing a test in sub-suite when beforeall fails in parent suite with logical suites in between.
Refactored `ut_teamcity_reporter` a bit.

jgebal force-pushed the feature/suite_query_api branch from 26eb3ca to 74ec9a1 Compare

November 18, 2018 15:03

jgebal added 6 commits

November 18, 2018 15:35


          Recovering exception handlers as they are needed for handling invalid…

44d61d9

… object names.


          Moved some of old tests into new tests.

360a889

Disabled coverage gathering on old tests.


          Added missing endcontext in test_ut_test

0ee3ce2


          Removed unused constants.

48aa338


          Added additional test for display of parser warnings.

b33aaae

Fixed issue with warnings not getting shown.


          Merge branch 'develop' into feature/suite_query_api

e8ea644

jgebal merged commit 3a1227e into develop

jgebal mentioned this pull request

Running tests by package name should only run that package #776

Closed

jgebal deleted the feature/suite_query_api branch

November 18, 2018 23:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Pazus Awaiting requested review from Pazus

lwasylow Awaiting requested review from lwasylow

PhilippSalvisberg Awaiting requested review from PhilippSalvisberg

1 more reviewer

utplsql-travis utplsql-travis left review comments

Labels

None yet