Fixed issue with sonar scanner failing on PR's from other repositories. #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasylow
reviewed
Jul 17, 2018
lwasylow
reviewed
Jul 17, 2018
Member
lwasylow
left a comment
lwasylow
left a comment
There was a problem hiding this comment.
Should that if not be inside if, as part of if Travis pull request - ne false and... ? The same code runs for pr and branch. If we run on branch then if condition for Travis pull repo will be empty?? That would stop branch running right?
Member
Author
|
I think you're right. |
…able_sonar_pr_from_others
…LSQL/utPLSQL into feature/disable_sonar_pr_from_others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.