Skip to content

Conversation

@lwasylow
Copy link
Member

Add option of using a coma separated string of test names.
Fixes #479

@lwasylow lwasylow changed the title Initial checkin Added Support to pass comma delimited list of test names Jul 12, 2018
Copy link
Member

@jgebal jgebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation needs to be updated as well to describe the new functionality.

procedure generate_invalid_spec;
procedure drop_test_package;

procedure create_test_csl_packages;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it a context and use beforeall / afterall inside context?
That way the package will get created/dropped only once.

begin
select *
bulk collect into l_results
from table(ut3.ut.run('test_csl_names1,test_csl_names2'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add spaces / tabs instde the text to validate that it still works?

execute immediate 'drop package invalid_pckag_that_revalidates';
execute immediate 'drop package parent_specs';
end;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cover all 3 changed entry points (procedures) with tests so we have regression for each of them?

@jgebal jgebal added this to the 3.1.2 milestone Jul 15, 2018
@jgebal
Copy link
Member

jgebal commented Jul 17, 2018

We should move the logic chane to ut_runner and convert each element of ut_varchar2_list that contains a comma separated list of paths.

@lwasylow
Copy link
Member Author

I have updated tests, moved decomposing of coma separated list into ut_runner and updated docs.

Copy link
Member

@jgebal jgebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jgebal jgebal merged commit 9e64140 into develop Jul 18, 2018
@jgebal jgebal deleted the feature/coma_list branch July 18, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants