Fixed issue with Sonar Test reporter giving bad reports with suitepath. - #433
Merged
Conversation
jgebal
commented
Aug 2, 2017
| begin | ||
| l_expected := q'{##teamcity[testSuiteStarted timestamp='%' name='A suite for testing different outcomes from reporters'] | ||
| l_expected := q'{%##teamcity[testSuiteStarted timestamp='%' name='org'] | ||
| %##teamcity[testSuiteStarted timestamp='%' name='utplsql'] |
Member
Author
There was a problem hiding this comment.
@Pazus I'm not sure If this would actually be a valid sequence of messages on TeamCity.
Mainly due to the fact that we have suitepath=org.utplsql.utplsql.test.
Maybe teamcity suite name should actually show path? Like it is done in XUnit reporter (see the XUnit test below).
Fixed a bug where sonar_test_reporter was reporting test files as nested due to suitepath nesting.
Pazus
approved these changes
Aug 5, 2017
| l_expected varchar2(32767); | ||
| begin | ||
| l_expected := q'{##teamcity[testSuiteStarted timestamp='%' name='A suite for testing different outcomes from reporters'] | ||
| l_expected := q'{%##teamcity[testSuiteStarted timestamp='%' name='org'] |
Member
There was a problem hiding this comment.
For TC starting new suite automatically closes the previous one, so please revert the change
https://confluence.jetbrains.com/display/TCD10/Build+Script+Interaction+with+TeamCity#BuildScriptInteractionwithTeamCity-Supportedtestservicemessages
Member
There was a problem hiding this comment.
Maybe TC reporter does need somу changes. The first test in the suite should start the new suite actually...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #413
@Pazus, please verify the test for TeamCity test reporter as it seems to be giving suspicious outputs with suitepath too.
Do we need to fix this?