Skip to content

Fixed flaky tests #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 1 commit into from
Mar 14, 2020
Merged

Fixed flaky tests #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions test/ut3_user/expectations/test_expectations_cursor.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,13 +419,12 @@ create or replace package body test_expectations_cursor is
as
l_expected sys_refcursor;
l_actual sys_refcursor;
l_date date := sysdate;
l_second number := 1/24/60/60;
c_second constant number := 1/24/60/60;
begin
--Arrange
ut3.ut.set_nls;
open l_actual for select l_date as some_date from dual;
open l_expected for select l_date-l_second some_date from dual;
open l_actual for select gc_date as some_date from dual;
open l_expected for select gc_date - c_second some_date from dual;
--Act
ut3.ut.expect( l_actual ).to_equal( l_expected );
--Assert
Expand All @@ -439,8 +438,8 @@ create or replace package body test_expectations_cursor is
l_expected sys_refcursor;
begin
--Arrange
open l_actual for select sysdate as some_date from dual;
open l_expected for select to_date(to_char(sysdate)) as some_date from dual;
open l_actual for select gc_date as some_date from dual;
open l_expected for select to_date(to_char(gc_date)) as some_date from dual;
--Act
ut3.ut.expect(l_actual).to_equal(l_expected);
--Assert
Expand Down Expand Up @@ -1970,10 +1969,10 @@ Diff:%
l_actual_tab some_object;
l_expected_tab some_object;
begin
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
into l_actual_tab from dual;

select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
into l_expected_tab from dual;

--Arrange
Expand All @@ -1994,10 +1993,10 @@ Diff:%
l_actual_tab some_object;
l_expected_tab some_object;
begin
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
into l_actual_tab from dual;

select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
into l_expected_tab from dual;

--Arrange
Expand All @@ -2018,10 +2017,10 @@ Diff:%
l_actual_tab some_object;
l_expected_tab some_object;
begin
select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
into l_actual_tab from dual;

select some_object( user,'TEST', sysdate, some_items( some_item(1,'test'), some_item(2,'test') ) )
select some_object( user,'TEST', gc_date, some_items( some_item(1,'test'), some_item(2,'test') ) )
into l_expected_tab from dual;

--Arrange
Expand All @@ -2043,12 +2042,11 @@ Diff:%
l_expected_tab some_object;
l_expected_message varchar2(32767);
l_actual_message varchar2(32767);
l_date date := sysdate;
begin
select some_object( 'TEST','TEST', l_date, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
into l_actual_tab from dual;

select some_object( 'TEST','TEST', l_date, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
into l_expected_tab from dual;

--Arrange
Expand Down Expand Up @@ -2080,10 +2078,10 @@ Diff:%
l_expected_message varchar2(32767);
l_actual_message varchar2(32767);
begin
select some_object( 'TEST','TEST', sysdate, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'BAD'), some_item(2,'test') ) )
into l_actual_tab from dual;

select some_object( 'TEST','TEST', sysdate, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
select some_object( 'TEST','TEST', gc_date, some_items( some_item(1,'TEST'), some_item(2,'test') ) )
into l_expected_tab from dual;

--Arrange
Expand Down