USWDS-Site - HTMLProofer: Update links to target redirects #2604
Conversation
finekatie
left a comment
finekatie
left a comment
There was a problem hiding this comment.
Links look good!
Would love to have convo about change log. I did an audit of the page months ago. We have another PR out there for this page for three other link fixes, so this is good timing.
amyleadem
left a comment
amyleadem
left a comment
There was a problem hiding this comment.
LGTM! Confirmed the updated links and ran npm run proof without error
|
Also, it would be helpful to include "HTML proofer" in the title of the issue - it should help with understanding the importance of the issue at a glance. |
mahoneycm
changed the title
mahoneycm
changed the title
mejiaj
left a comment
mejiaj
left a comment
There was a problem hiding this comment.
Looks good, new links work as expected.
| changelogURL: | ||
| items: | ||
| - date: NNNN-NN-NN | ||
| - date: 2024-03-29 |
There was a problem hiding this comment.
Note
We neglected to update this date when we merged USWDS-Site - Accessibility page: Replace content #2561. It should not be updated to match the merge date of this PR.
Summary
Updated treasury.gov and digital.gov links. Now, links no longer redirect or cause
htmlproofererrors.Important
We should confirm the changelog date in
_data/changelogs/docs-sample-contract-language.ymlbefore merge.Related issue
Closes #2603
Preview link
Showcase page →
Note
Not a user facing change due to redirect already bringing users here. Opted to not create a changelog for showcase.
Sample contract language page →
Problem statement
HTMLProofer flagged two new issues caused by the target pages updating. The
treasury.goverror was caused by a redirect tohome.treasure.govwhile thedigital.govlink was caused by the hash target no longer existing.Solution
Update links to reflect the current state of their target pages.
Testing and review
npm run proofdoes not flag any errors.