-
Notifications
You must be signed in to change notification settings - Fork 199
USWDS-Site - Accessibility page: Replace content #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amycole501
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page looks good! I read it and checked the links they appear to all work.
|
Thanks for flagging that @amycole501. I got word that the digital.gov team is working now to fix that 404. |
- This resolves an html proofer error
mahoneycm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are just a few small inconsistencies with the Accessibility page draft that I caught. Content and sidenav links look and work as expected!
| layout: styleguide | ||
| title: Accessibility | ||
| category: How to use USWDS | ||
| lead: Usability for every ability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subtitle period
Subtitle missing period. Seems like most other subtitles feature a period at the end of their sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, but also most of the others are complete sentences. I'm ok with leaving the period out here for now. When we follow up and refine this page we should re-evaluate the subtitle. I added to that to issue #2584.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, whenever we take a look at subtitles more broadly, I'd suggest we consistently not use periods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annepetersen - I like the idea making the subtitles a complete sentence and using them to provide an overview of the page and its value. For example, MailChimp uses subtitles this way. But I'm looking forward to hearing more about your perspective and discussing with the team. Regardless of what we decide, increasing consistency will be valuable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"brand"-wise, I think it's too formal for us, personally, but we can discuss
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
| layout: styleguide | ||
| title: Accessibility | ||
| category: How to use USWDS | ||
| lead: Usability for every ability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, but also most of the others are complete sentences. I'm ok with leaving the period out here for now. When we follow up and refine this page we should re-evaluate the subtitle. I added to that to issue #2584.
Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
mahoneycm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous change requests resolved by @sarah-sch. Lgtm! 👍

Summary
Updated the content on the accessibility page to match the content in the Accessibility page draft (Google docs 🔒) .
Note
Because this is a time sensitive update, we are taking an iterative approach to developing this content. In this initial phase, we are updating the text content only. Later, in issue #2568 we will work on enhancing the visual organization.
Related issue
Closes #2554
Preview link
Accessibility page
Testing and review