Skip to content

USWDS-Site: Fix typos in compile instructions #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thisisdano merged 10 commits into from
Apr 26, 2024
Merged

USWDS-Site: Fix typos in compile instructions #2401

thisisdano merged 10 commits into from
Apr 26, 2024

Conversation

@amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Dec 18, 2023 •
edited
Loading

Summary

  • Fixed typos and outdated references on the Phase 2: Compile and Packages pages.
  • Added documentation for projectIcons and projectIconsOnly settings for uswds-compile

Important

We should update changelog dates before merge

Related issue

Closes #2288

Preview link

Problem statement

There are a few outdated references and typos in our documentation. We should confirm that our uswds-compile settings documentation is up-to-date and accurate.

Testing and review

  1. Confirm that the information in the settings table matches the uswds-compile readme.
  2. Confirm that all issues outlined in issue USWDS-Site - Bug: Minor typos in Getting Started/Phase 2 and Components/Packages #2288 have been fixed.

@amyleadem amyleadem marked this pull request as ready for review December 18, 2023 18:48
mahoneycm
mahoneycm approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

  • Paths match uswds-compile instructions
  • Typos in #2288 are resolved

amyleadem
amyleadem commented Apr 26, 2024
View reviewed changes
_data/changelogs/docs-getting-started-devs-phase-2.yml Outdated
type: documentation
changelogURL:
items:
- date: NNNN-NN-NN
Copy link
Contributor Author

@amyleadem amyleadem Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

We should update changelog dates before merge

thisisdano
thisisdano reviewed Apr 26, 2024
View reviewed changes
thisisdano
thisisdano reviewed Apr 26, 2024
View reviewed changes
@thisisdano thisisdano merged commit 3e60cdf into main Apr 26, 2024
@thisisdano thisisdano deleted the al-compile-typos branch April 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annepetersen annepetersen Awaiting requested review from annepetersen

3 more reviewers

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano thisisdano approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: Minor typos in Getting Started/Phase 2 and Components/Packages

5 participants

@amyleadem @mejiaj @thisisdano @mahoneycm