USWDS - Docs: Add documentation for "$theme-prefix-separator". #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
HTMLProofer is reporting a 301 for two links [report]. They're completely accessible, but still appearing. For the Links > External check, the following failures were found:
* At ./_site/about/updates/index.html:3088:
External link https://vets.gov failed: got a time out (response code 301) (status code 301)
* At ./_site/documentation/showcase/index.html:2791:
External link https://va.gov failed: got a time out (response code 301) (status code 301)
HTML-Proofer found 2 failures!
Exited with code exit status 1
|
mahoneycm
approved these changes
Mar 16, 2023
Contributor
mahoneycm
left a comment
mahoneycm
left a comment
There was a problem hiding this comment.
Looks great! I ran npm run proof and did not get any failures
Contributor
Author
|
Closing in favor of #2016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added documentation for
$theme-prefix-separatorto General Settings table.Related issue
Closes #2030.
Preview link
Preview link: Settings page
Problem statement
This setting was added in to USWDS in
2.11.0and later the change was documented in changelog, but we never wrote any guidance for it.Solution
$theme-prefix-separatorto General SettingsMajor changes
Two new entries on Settings page.
Variable with documentation in general settings
Changelog entry
Testing and review
$theme-prefix-separatoris in General Settings Table