USWDS-Site: Vivid variable typos on Settings page #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
approved these changes
Sep 12, 2022
Contributor
mejiaj
left a comment
mejiaj
left a comment
There was a problem hiding this comment.
Great, thanks for this PR!!
Contributor
|
@pglevy are you able to pull in the latest changes from |
Contributor
Author
|
Hmm… I merged the changes from upstream/main, but the build test still seems to be failing with the same |
Contributor
Thank you, I'm pulling these changes into a local branch so the tests can run properly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variables for
primary-vividandsecondary-vividare incorrect. (They repeat the variables forprimaryandsecondaryinstead of using the associated vivid variable.)Additional information
n/a
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.