USWDS-Site - Implementation Page: Added USWDS for Rails #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
approved these changes
Apr 6, 2022
Contributor
amyleadem
left a comment
amyleadem
left a comment
There was a problem hiding this comment.
Looks good to me. I don't know how we normally order these, but I like the idea of placing the newest in the top.
mejiaj
reviewed
Jun 7, 2022
Contributor
mejiaj
left a comment
mejiaj
left a comment
There was a problem hiding this comment.
Thanks!
These are ordered alphabetically by Distribution let's stick to that convention. Could you update the order?
Contributor
|
@mejiaj I have pulled in |
amyleadem
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Implementations →
Description
Resolves #1499
Adds Damian Burke's (Talaria Software) Implementation of USWDS using Rails to the Implementations page
Additional information
I placed it at the beginning but we can move it elsewhere if need be!
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.