Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 15, 2021

Description

Resolves #1038

The documentation in _components/utilities/layout-grid.md referred to the max site width variable instead of the max grid container width variable to adjust the grid container's max width. I updated the documentation with the suggested edit from the issue.

@mejiaj
Copy link
Contributor

mejiaj commented Mar 15, 2021

@thisisdano should we move $theme-site-max-width to _deprecated.scss in USWDS?

@thisisdano
Copy link
Contributor

Sure, we could move it there with the value of $theme-grid-container-max-width

@mejiaj mejiaj self-requested a review March 15, 2021 21:38
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a search and replace for this now deprecated variable.

@mejiaj
Copy link
Contributor

mejiaj commented Mar 29, 2021

Closing in favor of local and up-to-date PR #1198

@mejiaj mejiaj closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect grid width variable in docs ($theme-site-max-width vs $theme-grid-container-max-width)

2 participants