USWDS - Unit Tests: Fix USWDS build unit test #6417
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
commented
Feb 18, 2025
| ], | ||
| "exit": true, | ||
| "timeout": 4000 | ||
| "timeout": 6000 |
Contributor
Author
There was a problem hiding this comment.
note: Timeout increased to give the compilation process more time to complete. Alternatively, we can set this timeout specifically for the before() hook in build.spec.js
Comment on lines
+25
to
+28
|
|
||
| buildTests() { | ||
| return src("src/test/build.spec.js").pipe(mocha(mochaConfig)); | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
note: I opted to create a separate test function here so since this test is unrelated to component code. Including it in our other tests would slow them down due to the compilation process.
mahoneycm
commented
Feb 18, 2025
Contributor
Author
There was a problem hiding this comment.
question: This test currently checks for uswds.css. and uswds.min.css. Should we add a new test for uswds.min.css.map since it's output by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the existing
build.spec.jstest which tests USWDS css output.Breaking change
This is not a breaking change.
Related issue
Closes #6413
Preview link
Preview link →
Problem statement
The current unit test fails when being ran and does not have a script to easily run it.
Solution
compileSassinstead ofsasswhich no longer existsbuildTeststest script intest.jspackage.jsonto run this testMajor changes
npm run test:buildNote
This build script is currently only testing output
css. Since this is all it was checking before I wanted to scope the work to fixing the existing functionality.I’ve created #6415 to consider adding additional tests to check for other dist files.
Testing and review
/distdirectorynpm run test:build/distis rebuilt with css dir:uswds.cssuswds.min.cssuswds.min.css.map