USWDS - Hotfix: Remove classlist-polyfill dependency #6012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heymatthenry
approved these changes
Aug 6, 2024
mahoneycm
changed the title
amyleadem
approved these changes
Aug 6, 2024
Contributor
amyleadem
left a comment
amyleadem
left a comment
There was a problem hiding this comment.
Looks good to me. I was able to successfully complete the following:
- Run
npm install - Run
npm start
Components as expected in Chrome, Safari, and Firefox.
Contributor
|
Oh, one small note: It might be good to add a note to the "Breaking change" section of the PR description that this will remove some IE11 support. Just think it would be good to be super clear in case there are projects that still support IE? |
Contributor
|
While this dependency has a potential DoS vulnerability via regex, we don't consider it exploitable from the front end of applications. Even so, it make sense to remove this dependency. |
thisisdano
approved these changes
Aug 9, 2024
Merged
claytonjbarnette
added a commit
to GSA/idmanagement.gov
that referenced
this pull request
Aug 12, 2024
Updated USWDS to v3.8.2 - [new release](https://github.com/uswds/uswds/releases/tag/v3.8.2) - [Removed the `classlist-polyfill` dependency in issue 6012](uswds/uswds#6012)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the IE11
classlist-polyfilldependency that caused a DoS VulnerabilityBreaking change
This is a potentially breaking change.
This polyfill added support for the classList property in IE11, which now has partial support.
Related issue
Closes #6008
Related pull requests
The remaining IE11 polyfills are removed in #4692
Preview link
Storybook preview →
Problem statement
The
classlist-polyfilldependency was causing a DoS vulnerability affecting downstream projects.Solution
Remove the polyfill now that IE11 is no longer officially supported.
Testing and review
npm installand confirm there are no issuesnpm run startand confirm there are no build errorsDependency updates
1.2.0