Skip to content

USWDS - Header: Use $theme-header-min-width for safari fix calc #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thisisdano merged 7 commits into from
Dec 8, 2023
Merged

USWDS - Header: Use $theme-header-min-width for safari fix calc #5624

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3bce77
Use $theme-header-min-width for safari fix calc
Nov 17, 2023
21c3469
Check for "none" value before safari fix
Dec 6, 2023
e7939f7
Scope safari fix to only work with expected values
Dec 6, 2023
e99b5b0
Safari fix checks for "none" and negative values
Dec 6, 2023
85aae5e
Check for "auto" before safari fix
Dec 7, 2023
8a212d1
Clean up safari fix token check
Dec 7, 2023
4ffcfa0
Only apply Safari fix if given a breakpoint token
Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions packages/usa-nav/src/styles/_usa-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@use "sass:map";
@use "uswds-core" as *;

// Navigation helpers
Expand Down Expand Up @@ -475,19 +476,26 @@ $expand-less-icon: map-merge(
}

// Safari-only fix that forces a vertical scrollbar when mobile menu is open.
// Only needed in the 15px immediately preceding $theme-header-max-width.
// Only needed in the 15px immediately preceding $theme-header-min-width.
//
// Note: 15px is the current width of the Safari scrollbar.
// More details in https://github.com/uswds/uswds/pull/5443
$safari-header-bug-min-width: calc(
units($theme-header-max-width) - px-to-rem(15px)
);

@media (min-width: $safari-header-bug-min-width) {
.usa-js-mobile-nav--active.is-safari {
overflow-y: scroll;
position: fixed;
// --scrolltop set with JS with zero as fallback.
top: var(--scrolltop, 0);
// Note: This fix only applies when $theme-header-min-width is defined with a system breakpoint
// because the header visually breaks with other values.
// This bypass prevents compilation errors with values like "none" or 1px.

$our-breakpoints: map-deep-get($system-properties, breakpoints, standard);

@if map-has-key($our-breakpoints, $theme-header-min-width) {
$safari-header-bug-min-width: calc(
units($theme-header-min-width) - px-to-rem(15px)
);

@media (min-width: $safari-header-bug-min-width) {
.usa-js-mobile-nav--active.is-safari {
overflow-y: scroll;
position: fixed;
// --scrolltop set with JS with zero as fallback.
top: var(--scrolltop, 0);
}
}
}