USWDS - Button: Remove aria_disabled control #5474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
approved these changes
Sep 1, 2023
Contributor
mahoneycm
left a comment
mahoneycm
left a comment
There was a problem hiding this comment.
Lgtm!
- Confirmed
aria-disabledcontrol is not needed - Confirmed control is appropriately removed
mejiaj
approved these changes
Sep 8, 2023
thisisdano
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the outdated
aria_disableddata item from the button story.Breaking change
This is not a breaking change.
Related issue
Closes #5395
Related pull requests
No changelog needed since this is an internal-facing change.
Preview link
Button component
Problem statement
The button story templates were refactored in #5063 to remove the conditional check for
aria_disabled. However, theusa-button.jsonfile still has the outdatedaria_disableddata item.Solution
Removed the outdated
aria_disableddata item from the button story.All other
aria_disableddata references for button were removed in #5063. It appears as though this one was accidentally left out.Testing and review
aria-disableddata itemaria_disableddata item (and Storybook control) were removed