USWDS - Bump stylelint, @18f/identity-stylelint-config, and postcss #5373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.13.0 to 15.10.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@14.13.0...15.10.1) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
This was referenced Jul 12, 2023
amyleadem
approved these changes
Jul 13, 2023
Contributor
amyleadem
left a comment
amyleadem
left a comment
There was a problem hiding this comment.
Looks good!
- Confirmed that there are no errors after running a clean
npm install,npm run lintandnpm run start - Confirmed that linting catches Sass code style errors
- Styles appear to be intact
mejiaj
approved these changes
Jul 17, 2023
Contributor
mejiaj
left a comment
mejiaj
left a comment
There was a problem hiding this comment.
LGTM, I tested for:
- Install errors
- Linting errors
- Compilation errors
- Visual regressions
thisisdano
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump
stylelint,@18f/identity-stylelint-config, andpostcssto resolve semver vulnerability.Breaking change
This is not a breaking change.
Related issue
Closes Dependabot alert #61
Related pull requests
Dependabot Security Update #5366
Preview link
Preview link:
USWDS →
Problem statement
Stylelinthas vulnerability in semver dependency.Updating this dependency alone causes conflicts with
@18f/identity-stylelint-configwhich, when updated alone, causes a conflict withPostcssSolution
Bump
stylelintand relevant dependencies that are needed in order to prevent errors.stylelint 14.13.0 → 15.10.1@18f/identity-stylelint-config 1.0.0 → 2.0.0postcss 8.4.0 → 8.4.19Dependency updates
Testing and Review
npm installand confirm no installation errorsnpm run lint:sassnpm run startTesting checklist
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch isdevelop).npm run prettier:sassto format any Sass updates.npm testand confirm that all tests pass.