USWDS - [usa-icon-list] Add support for $theme-body-font-size to be 2xs #5356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
approved these changes
Jun 30, 2023
Contributor
mahoneycm
left a comment
mahoneycm
left a comment
There was a problem hiding this comment.
Thanks for flagging and contributing! This is working as expected for me!
- Setting
$theme-body-font-size: "2xs"doesn't result in any build errors - Components that use
$theme-body-font-sizeare updated correctly without any negative visual regression - Sass functions that use
$theme-body-font-sizeaccept the value and do not error
@mejiaj @amycole501 Looking ahead, would it be in our best interest to include "3xs": $theme-type-scale-3xs to cover all of the Type scale values?
This was referenced Jul 7, 2023
Contributor
|
@paulathevalley Thank you for submitting this issue and PR. This PR works well, but it more importantly exposed a bigger issue with the component code not fitting current system patterns. To fix this larger issue, I have opened PR #5363 as an alternate approach. Thanks again for your contribution! I am going to close this PR in favor of #5363, but please let us know if you have questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow
$theme-body-font-sizeto be set to2xsin uswds-theme.Breaking change
This is not a breaking change.
Related issue
Closes #5357
Problem statement
Summarize the problem this PR solves in a clear and concise statement.
Setting
$theme-body-font-sizeto'2xs'unexpectedly throws an error, blocking the page render.Solution
Provide a summary of the solution this PR offers.
This PR:
'2xs': $theme-type-scale-2xsto the list of available font-sizesThere may be a more robust way to grab all the possible type-scale theme variables instead of manually updating them by key here. I am also unclear whether there was a conscious decision to support a limited set of sizes.
In our use case, the
$theme-type-scale-2xsis set to token6which is roughly17px.Testing and review
Share recommended methods for reviewing this change.
In
_uswds-theme.scss:Error message is resolved and page loads.