USWDS - Megamenu: Recalculate width of outer-megamenu elements #4757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
commented
Jun 2, 2022
Comment on lines
+13
to
+16
| $mw: smart-quote($header-max-width); | ||
| @if meta.type-of($header-max-width) == "string" { | ||
| $mw: units($header-max-width); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Checking for type in case user adds a unit value instead of a USWDS value. This maintains current capabilities.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4234
Preview links:
Problem
The
.usa-megamenu.usa-nav__submenu::afterand.usa-megamenu.usa-nav__submenu::beforepseudo elements that surround the navigation on our megamenu extend beyond the viewport. This can cause problems when trying to capture screenshots, as well as other potential unknown issues.Solution
Currently, these pseudo elements are set to a width of 100%, which is wider than they need to be and causes the elements to extend beyond the viewport.
Recalculating the width using relevant theme settings values allows the pseudo elements to line up with the edge of the viewport.
Testing
Because our header closes on click, I found the best method for testing this is to open desired story and not hit refresh to initialize the component.
megamenuandextended megamenuvariants in Storybook.usa-megamenu.usa-nav__submenu::afterand.usa-megamenu.usa-nav__submenu::beforeelements.Additional information
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.