Summary

uswds-init is better at suppressing FOUC. We updated the uswds-init script's event listener to target window from document. This assures that the page's JavaScript is fully loaded before we remove the loadingClass that suppresses the open banner. The banner should no longer flash open.

Related Issue

Closes uswds/uswds-site#1559

Solution

Changed the target of the event listener from document to window in uswds-init.js. Testing shows that window load appears to finish after document load. By moving targets, we ensure the page is fully loaded prior to removing the loadingClass.

Testing and review

To see the fix in action, check out this USWDS-site preview link ➡️

Notes

• window vs document load test
• uswds-init load event rebuilt in in 2.12.1
  • uswds-init in 2.12.0
  • uswds-init in 2.12.1
  • changed file

Additional information

Before you hit Submit, make sure you’ve done whichever of these applies to you:

• Follow the 18F Front End Coding Style Guide and Accessibility Guide.
• Run npm test and make sure the tests for the files you have changed have passed.
• Run your code through HTML_CodeSniffer and make sure it’s error free.
• Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.