Skip to content

Conversation

@mahoneycm
Copy link
Contributor

Description

Resolves issue #4142 by adding the medium-negative system-tokens to _spacing-tokens.scss as well as _properties.scss.

Additional information

Input before:

@include u-margin-x("neg-4");

left unexpected output:
messageOriginal: "'neg-4' is not a valid USWDS margin-horizontal token. Valid tokens: 1px, 2px, 05, 1, 105, 2, 205, 3, neg-1px, neg-2px, neg-05, neg-1, neg-105, neg-2, neg-205, neg-3, 4, 5, 6, 7, 8, 9, 10, 15, card, card-lg, mobile, 05em, 1em, 105em, 2em, 0, auto" ╷ 57 │ @return uswds-error( │ ┌───────────^ 58 │ │ "'#{$token}' is not a valid USWDS #{$type} token.#{$valid-token-message}" 59 │ │ ); │ └───^

The error does not occur with this build..

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • [ x ] Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • [ x ] Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • [ x ] Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants