-
Notifications
You must be signed in to change notification settings - Fork 1.1k
2.11.0 bugfixes #4092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
2.11.0 bugfixes #4092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
approved these changes
Mar 16, 2021
Contributor
Contributor
Author
Contributor
|
Checked again and am seeing it in IE11. Sorry about that. |
- Remove overflow (error state won't show otherwise) - Add margin for even space when input has a background
- Rewrite input custom sizes - Display input-group as inline flex/width: auto to fit to custom input sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Alert icon position
The icon position in site alert regressed when we implemented color icon in alerts. This updates the padding and margin in the various site alert variants.
This also reverts the icon alignment to top and reduces its size to be more like the previous icon size.
Before:

After:

Sortable table button hover
Fixed the hover state on the sortable indicator to fill the icon with the header text color, not the sorted header text color
Input prefix and suffix
--errorand ``--[size]variants toinput-group` just as we have them for `input`Example of dynamic color background (autofill in chrome) and prefix:

Banner
Fixed an alignment issue with the
Here's how you knowbutton. Note the button has moved down slightly to the text baseline.Before:

After:
