Checkbox, Radio: Prevent stray A circumflex (Â) #4080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USWDS - Build: Modify build tasks to get more reliable output on release.
thisisdano
approved these changes
Mar 12, 2021
Contributor
thisisdano
left a comment
thisisdano
left a comment
There was a problem hiding this comment.
Nice. This is a smart fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Âcharacter can show up where a non-breaking space should be when<meta charset="utf-8">isn't set properly. The non-breaking space character is byte 0xA0 in ISO-8859-1. When encoded to UTF-8 it'd be 0xC2,0xA0, which, if incorrectly viewed as ISO-8859-1 displays asÂ.This bug is manifesting in our app's radio buttons and checkboxes:
…since
content: "\a0";is used to render checkboxes and radios:uswds/src/stylesheets/elements/form-controls/_checkbox-and-radio.scss
Lines 40 to 48 in a683079
This change refactors the checkboxes and radios to use a regular space (and
white-space: pre;so it does not collapse). This prevent stray A circumflex (Â) characters from appearing next to checkboxes and radio buttons.