Skip to content

USWDS - Bug: Unused aria_disabled control on Button storybook preview #5436

@mahoneycm

Description

@mahoneycm

Describe the bug

The storybook preview for our Button component has a leftover, unused, aria_disabled control. The control is only referenced in usa-button.json and not included in the template or argTypes. Looks like it was leftover after we updated disabled form elements.

Steps to reproduce the bug

  1. Visit button storybook preview
  2. Try to enable aria_disabled control all button views
  3. Nothing changes
    4.aria_disabled is only mentioned in usa-button.json

Expected Behavior

The aria_disabled control was removed from the button story and included in the all states display as a part of #5063 and should be removed from the default button .json file.

Related code

No response

Screenshots

No response

System setup

No response

Additional context

It looks like this was initially removed as a part of 8c0c8b6 but when inspecting the changed files for #5063, usa-button.json appears to have been omitted somehow. All of the other variants show as having this removed as a part of this work. It maybe have been replaced accidentally as part of the collaborative work done on that large PR.

Code of Conduct

Metadata

Metadata

Assignees

Labels

Context: JavaScriptIssue is in JavaScriptRole: DevDevelopment/engineering skills needed

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions