-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Describe the bug
The storybook preview for our Button component has a leftover, unused, aria_disabled control. The control is only referenced in usa-button.json and not included in the template or argTypes. Looks like it was leftover after we updated disabled form elements.
Steps to reproduce the bug
- Visit button storybook preview
- Try to enable
aria_disabledcontrol all button views - Nothing changes
4.aria_disabledis only mentioned inusa-button.json
Expected Behavior
The aria_disabled control was removed from the button story and included in the all states display as a part of #5063 and should be removed from the default button .json file.
Related code
No response
Screenshots
No response
System setup
No response
Additional context
It looks like this was initially removed as a part of 8c0c8b6 but when inspecting the changed files for #5063, usa-button.json appears to have been omitted somehow. All of the other variants show as having this removed as a part of this work. It maybe have been replaced accidentally as part of the collaborative work done on that large PR.
Code of Conduct
- I agree to follow this project's Code of Conduct.
- I checked the current issues for duplicate bug reports.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status