Set [tool.deptry.ignore_notebooks] explicitly as deptry config#989
Conversation
CodSpeed Performance ReportMerging #989 will degrade performances by 3.51%Comparing Summary
Benchmarks breakdown
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Regression is expected since we're now writing |
There was a problem hiding this comment.
Pull Request Overview
This PR configures deptry to explicitly set [tool.deptry.ignore_notebooks] to false in the pyproject.toml file. This ensures deptry has an explicit configuration rather than relying on defaults.
- Adds explicit deptry configuration to set
ignore_notebooks = false - Updates the order of linter initialization to run deptry before ruff
- Updates test expectations to reflect the new configuration behavior
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/usethis/_tool/impl/deptry.py | Adds configuration item for ignore_notebooks setting |
| src/usethis/_core/tool.py | Adds call to add_configs() in use_deptry() function |
| src/usethis/_toolset/lint.py | Reorders linter initialization to run deptry before ruff |
| tests/usethis/_tool/impl/test_deptry.py | Updates test to expect pyproject.toml creation |
| tests/usethis/_core/test_core_tool.py | Adds test for ignore_notebooks setting and updates output expectations |
| tests/usethis/_core/test_rule.py | Updates expected output to include deptry config message |
| tests/usethis/_ui/interface/test_lint.py | Updates test expectations for new output order and pyproject.toml creation |
| tests/usethis/_ui/interface/test_init.py | Updates expected output order in test assertions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nathanjmcdougall
deleted the
983-deptry-has-no-default-config-doesnt-get-detected-in-bitbucket-integration-for-none-backend
branch
No description provided.