Remove idempotent encode-decode calls for unicode character#882
Merged
nathanjmcdougall merged 1 commit intomainfrom Jul 22, 2025
Merged
Conversation
I think this was added from a contributor without testing it was necessary. It seems to have no effect, so I've removed it. In hindsight, it was fairly clear it had no effect because the other unicode characters didn't use it. I also noticed an issue regarding missing messages when looking into this #881
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Instrumentation Performance ReportMerging #882 will not alter performanceComparing Summary
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was added from a contributor without testing it was necessary. It seems to have no effect, so I've removed it. In hindsight, it was fairly clear it had no effect because the other unicode characters didn't use it.
I also noticed an issue regarding missing messages when looking into this #881