Implement Dependency.to_requirements_string#861
Merged
nathanjmcdougall merged 2 commits intomainfrom Jul 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new method to format a Dependency as a requirements-style string and accompanying tests.
- Implements
Dependency.to_requirements_stringto emitname[extra1,extra2] - Introduces tests for no extras, single extra, and multiple extras cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/usethis/_integrations/uv/test_deps.py | Added TestDependency.TestToRequirementsString tests for the new method |
| src/usethis/_integrations/uv/deps.py | Implemented to_requirements_string in Dependency class |
Comments suppressed due to low confidence (1)
tests/usethis/_integrations/uv/test_deps.py:32
- pytest does not collect tests inside nested classes. Move these test methods into a top-level class (e.g.,
TestToRequirementsStringor flatten intoTestDependency) so they are discovered.
class TestToRequirementsString:
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
CodSpeed Instrumentation Performance ReportMerging #861 will not alter performanceComparing Summary
|
nathanjmcdougall
deleted the
850-a-method-on-the-dependency-object-to-display-it-as-a-requirements-string
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.