Skip to content

Catch broader FileConfigError rather than FileDecodeError in is_used #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 1 commit into from
Jun 28, 2025
Merged

Catch broader FileConfigError rather than FileDecodeError in is_used #816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/usethis/_tool/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from usethis._tool.config import ConfigSpec, NoConfigValue
from usethis._tool.pre_commit import PreCommitConfig
from usethis._tool.rule import RuleConfig
from usethis.errors import FileDecodeError
from usethis.errors import FileConfigError

if TYPE_CHECKING:
from pathlib import Path
Expand Down Expand Up @@ -109,7 +109,7 @@ def is_used(self) -> bool:
2. Whether any of the tool's managed files are in the project.
3. Whether any of the tool's managed config file sections are present.
"""
decode_err_by_name: dict[str, FileDecodeError] = {}
decode_err_by_name: dict[str, FileConfigError] = {}
_is_used = False

_is_used = any(
Expand All @@ -119,13 +119,13 @@ def is_used(self) -> bool:
if not _is_used:
try:
_is_used = self.is_declared_as_dep()
except FileDecodeError as err:
except FileConfigError as err:
decode_err_by_name[err.name] = err

if not _is_used:
try:
_is_used = self.is_config_present()
except FileDecodeError as err:
except FileConfigError as err:
decode_err_by_name[err.name] = err

for name, decode_err in decode_err_by_name.items():
Expand Down