Skip to content

Check whether a pre-commit hook is used as a part of is_used heuris…#813

Merged
nathanjmcdougall merged 5 commits intomainfrom
811-improve-is_used-heuristics-by-checking-pre-commit-config
Jun 28, 2025
Merged

Check whether a pre-commit hook is used as a part of is_used heuris…#813
nathanjmcdougall merged 5 commits intomainfrom
811-improve-is_used-heuristics-by-checking-pre-commit-config

Conversation

@nathanjmcdougall
Copy link
Copy Markdown
Collaborator

…tics

@nathanjmcdougall nathanjmcdougall linked an issue Jun 28, 2025 that may be closed by this pull request
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 28, 2025

CodSpeed WallTime Performance Report

Merging #813 will degrade performances by 3.92%

Comparing 811-improve-is_used-heuristics-by-checking-pre-commit-config (9e0a23d) with main (ca3e8e7)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_several_tools_add_and_remove 6.8 s 7.1 s -3.92%

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@nathanjmcdougall
Copy link
Copy Markdown
Collaborator Author

Regarding the performance regression, I suspect it is unavoidable simply due to the additional YAML read-in that is required to check for pre-commit config.

Maybe it could be alleviated somewhat via #492.

@nathanjmcdougall nathanjmcdougall merged commit 91e5716 into main Jun 28, 2025
18 checks passed
@nathanjmcdougall nathanjmcdougall deleted the 811-improve-is_used-heuristics-by-checking-pre-commit-config branch June 28, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve is_used heuristics by checking pre-commit config

1 participant