Skip to content

558 usethis tool coverage breaks existing config in some cases#560

Merged
nathanjmcdougall merged 24 commits intomainfrom
558-usethis-tool-coverage-breaks-existing-config-in-some-cases
Apr 26, 2025
Merged

558 usethis tool coverage breaks existing config in some cases#560
nathanjmcdougall merged 24 commits intomainfrom
558-usethis-tool-coverage-breaks-existing-config-in-some-cases

Conversation

@nathanjmcdougall
Copy link
Copy Markdown
Collaborator

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Apr 24, 2025 that may be closed by this pull request
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review April 25, 2025 07:05
@nathanjmcdougall
Copy link
Copy Markdown
Collaborator Author

nathanjmcdougall commented Apr 26, 2025

Should try and refactor to re-enable PLR0912 once the tests pass, also revisit whether we can revert the bump of tomlkit.

This reverts commit f17264c.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 26, 2025

CodSpeed Performance Report

Merging #560 will degrade performances by 76.8%

Comparing 558-usethis-tool-coverage-breaks-existing-config-in-some-cases (fc3fc17) with main (41d1feb)

Summary

❌ 1 (👁 1) regressions

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_several_tools_add_and_remove 213.2 ms 918.8 ms -76.8%

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (41d1feb) to head (fc3fc17).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   97.38%   97.39%           
=======================================
  Files         100      100           
  Lines        4325     4336   +11     
=======================================
+ Hits         4212     4223   +11     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanjmcdougall
Copy link
Copy Markdown
Collaborator Author

The performance regression corresponds to the improvement in other recent PR (can't find it without effort). It's unclear why it's happening though, so I'm ignoring the regression for now.

@nathanjmcdougall nathanjmcdougall merged commit 85f13c7 into main Apr 26, 2025
17 checks passed
@nathanjmcdougall nathanjmcdougall deleted the 558-usethis-tool-coverage-breaks-existing-config-in-some-cases branch April 26, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

usethis tool coverage breaks existing config in some cases

1 participant