558 usethis tool coverage breaks existing config in some cases#560
Merged
nathanjmcdougall merged 24 commits intomainfrom Apr 26, 2025
Merged
Conversation
…nfig-in-some-cases
…nfig-in-some-cases
Collaborator
Author
|
Should try and refactor to re-enable PLR0912 once the tests pass, also revisit whether we can revert the bump of |
This reverts commit f17264c.
CodSpeed Performance ReportMerging #560 will degrade performances by 76.8%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 97.38% 97.39%
=======================================
Files 100 100
Lines 4325 4336 +11
=======================================
+ Hits 4212 4223 +11
Misses 113 113 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
The performance regression corresponds to the improvement in other recent PR (can't find it without effort). It's unclear why it's happening though, so I'm ignoring the regression for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.