Handle other configuration file formats for coverage#415
Merged
nathanjmcdougall merged 4 commits intomainfrom Mar 28, 2025
Merged
Handle other configuration file formats for coverage#415nathanjmcdougall merged 4 commits intomainfrom
nathanjmcdougall merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends support for handling additional configuration file formats for coverage and adds support for list values in INI files. Key changes include:
- Adding new tests for list operations in TOML and INI file managers.
- Introducing new file manager classes (CoverageRCManager and ToxINIManager) and updating the configuration specification in the core tool.
- Implementing list extension and removal functionality in INI file I/O with detailed error messages.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/usethis/integrations/file/toml/test_io.py | Adds tests for list operations and error handling in TOML file management. |
| tests/usethis/_core/test_core_tool.py | Adds tests to verify content written to .coveragerc and tox.ini files. |
| src/usethis/_tool.py | Updates configuration specifications to support new file managers. |
| src/usethis/integrations/file/ini/io.py | Implements list extension and removal in INI file handling. |
| src/usethis/_config_file.py | Integrates new INI file manager classes into the files manager pipeline. |
CodSpeed Performance ReportMerging #415 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 98.02% 98.07% +0.04%
==========================================
Files 73 73
Lines 3350 3420 +70
==========================================
+ Hits 3284 3354 +70
Misses 66 66 ☔ View full report in Codecov by Sentry. |
nathanjmcdougall
deleted the
221-properly-handle-coverage-configuration-files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also needed to add list support for INI files for #402