Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for INI file integration to the module while updating configuration dependencies and test expectations. Key changes include:
- Introducing INIFileManager and associated error classes in the INI integration.
- Updating the pyproject.toml to include the configupdater dependency and expand supported file types.
- Adjusting TOML and pyproject.toml test cases by removing logic related to missing value errors.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/usethis/integrations/file/ini/io.py | Adds a new INI file manager with methods for reading, writing, and key access. |
| src/usethis/_integrations/file/ini/errors.py | Introduces error classes specific to INI file operations. |
| tests/usethis/integrations/file/toml/test_io.py | Updates tests to validate new behaviors in file management. |
| pyproject.toml | Updates dependency list and layering to include INI integration. |
| src/usethis/_io.py | Refactors init to set file paths and removes duplicate definitions. |
| src/usethis/integrations/file/toml/io.py | Removes the error raise for empty keys in configuration access. |
| tests/usethis/integrations/file/pyproject_toml/test_pyproject_toml_io.py | Adjusts deletion behavior to align with new error handling. |
| src/usethis/_integrations/file/pyproject_toml/errors.py | Removes unused error types related to missing values. |
| src/usethis/_integrations/file/toml/errors.py | Removes the TOMLValueMissingError related code changes. |
Comments suppressed due to low confidence (1)
src/usethis/integrations/file/ini/io.py:69
- The _content getter returns 'super()._content' while the setter assigns to '_content_by_path'. This mismatch may cause inconsistencies when reading the value; consider aligning the getter to retrieve the value from _content_by_path.
@property
CodSpeed Performance ReportMerging #402 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 98.39% 98.48% +0.08%
==========================================
Files 69 71 +2
Lines 3113 3290 +177
==========================================
+ Hits 3063 3240 +177
Misses 50 50 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.