Skip to content

Skip test_bad_commit online variant on CI #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 2 commits into from
Mar 31, 2026
+4 −0
Merged

Skip test_bad_commit online variant on CI #1676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35a8333
Initial plan
Copilot Mar 31, 2026
88abdc0
Skip test_bad_commit online variant on CI to avoid flakiness
Copilot Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/usethis/_core/test_core_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import subprocess
import unittest
import unittest.mock
Expand Down Expand Up @@ -1890,6 +1891,9 @@ def test_config_file_already_exists(self, uv_init_repo_dir: Path):
def test_bad_commit(self, uv_env_dir: Path, git_path: Path):
# This needs a venv so that we can actually run pre-commit via git

if os.environ.get("CI") and not usethis_config.offline:
pytest.skip("Skipping online test on CI to avoid flakiness")

# Arrange
(uv_env_dir / ".gitignore").write_text(".venv/\n")

Expand Down
Loading