Skip test_bad_commit online variant on CI#1676
Merged
nathanjmcdougall merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/b55d7512-e4ca-4071-a97f-7771fa1e9063 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI to run test_bad_commit test offline only
Skip test_bad_commit online variant on CI
Mar 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
added a commit
that referenced
this pull request
Apr 1, 2026
…ing ones (#1659) * Initial plan * Configure agents to fix all static check failures including pre-existing ones - Add "Fix all failures, including pre-existing ones" section to usethis-qa-static-checks SKILL.md (v1.6→v1.7) - Strengthen usethis-qa-static-checks guidance in AGENTS.md - Update usethis-python-code-modify SKILL.md (v1.3→v1.4) to reinforce the requirement Resolves #1676 Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/f86eed16-423e-469c-87e9-6f84dbfe3755 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> Co-authored-by: Nathan McDougall <nathan.j.mcdougall@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_bad_commitaccessessync-with-uvon GitHub during the ONLINE parametrized variant, causing flaky CI failures. Skip the online variant when running on CI; locally both variants still run.CIenv var is set andusethis_config.offlineisFalse(i.e. the ONLINE variant of_vary_network_conn)