Emphasize static checks are required for all changes, including doc-only#1669
Merged
nathanjmcdougall merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
- Updated AGENTS.md to explicitly state static checks apply to ALL changes including documentation-only changes and skill file edits - Updated usethis-qa-static-checks SKILL.md with concrete examples of hooks that catch non-code regressions (check-doc-sync, export-functions) - Bumped skill version 1.6 → 1.7 Resolves #1666 Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/857e36e6-f481-42a2-af79-1e6db303df34 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update AGENTS.md to emphasize running static checks for doc-only changes
Emphasize static checks are required for all changes, including doc-only
Mar 31, 2026
nathanjmcdougall
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1665, the agent skipped static checks for a documentation-only change. The existing AGENTS.md wording ("if you think your task is complete") was too conditional—agents interpreted it as optional for non-code changes.
AGENTS.md: Rewrote theusethis-qa-static-checksbullet to remove conditional phrasing and explicitly state it applies to ALL changes including doc-only and skill edits, with rationale (sync issues, formatting)usethis-qa-static-checksSKILL.md: Expanded "When to run" to name concrete hooks (check-doc-sync,export-functions) that catch non-code regressions; bumped version 1.6 → 1.7