Instruct agents to fix all static check failures, including pre-existing ones#1659
Merged
nathanjmcdougall merged 3 commits intomainfrom Mar 31, 2026
Merged
Conversation
…ing ones - Add "Fix all failures, including pre-existing ones" section to usethis-qa-static-checks SKILL.md (v1.6→v1.7) - Strengthen usethis-qa-static-checks guidance in AGENTS.md - Update usethis-python-code-modify SKILL.md (v1.3→v1.4) to reinforce the requirement Resolves #1676 Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/f86eed16-423e-469c-87e9-6f84dbfe3755 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add compliance instructions for static checks in agents
Instruct agents to fix all static check failures, including pre-existing ones
Mar 30, 2026
nathanjmcdougall
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents were not clearly told to fix static check failures that predate their PR. CI enforces checks on the entire codebase, so pre-existing failures block PRs just the same.
usethis-qa-static-checksSKILL.md (v1.6→v1.7): New section "Fix all failures, including pre-existing ones" with rationale and escape hatch for large-refactor casesAGENTS.md: Strengthened theusethis-qa-static-checksbullet in "Generally Important Instructions"usethis-python-code-modifySKILL.md (v1.3→v1.4): Reinforced the same expectation in "Run static checks after finishing modifications"