Clarify that files modified in prek runs are still failures#1580
Merged
nathanjmcdougall merged 3 commits intomainfrom Mar 27, 2026
Merged
Clarify that files modified in prek runs are still failures#1580nathanjmcdougall merged 3 commits intomainfrom
nathanjmcdougall merged 3 commits intomainfrom
Conversation
Update usethis-qa-static-checks skill (v1.5 → v1.6) to explicitly document that file modifications by hooks count as failures, even when all individual hooks show "Passed" or "Skipped". Closes #1561 Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/c719f2a0-31b5-4d19-b60f-ed4f47bd1bf9 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Clarify that modified files in prek runs are still failures
Clarify that files modified in prek runs are still failures
Mar 27, 2026
nathanjmcdougall
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents were misinterpreting prek output where all individual hooks show "Passed"/"Skipped" but the overall run fails due to
Files were modified by following hooks. This edge case came up in #1558.usethis-qa-static-checksskill (v1.5 → v1.6) that file modifications by hooks (e.g. auto-formatting) constitute a failure requiring a re-run to confirm a clean pass📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.