Only exclude _version from top-level Import Linter contracts#1536
Merged
nathanjmcdougall merged 2 commits intomainfrom Mar 25, 2026
Merged
Only exclude _version from top-level Import Linter contracts#1536nathanjmcdougall merged 2 commits intomainfrom
_version from top-level Import Linter contracts#1536nathanjmcdougall merged 2 commits intomainfrom
Conversation
…t submodule contracts Closes #1432 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/385f0827-605c-428f-8947-960907d3c5a9
Copilot
AI
changed the title
[WIP] Add test for version inclusion in Import Linter contracts
Only exclude Mar 25, 2026
_version from top-level Import Linter contracts
nathanjmcdougall
approved these changes
Mar 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
deleted the
copilot/test-version-inclusion-import-linter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_versionwas being excluded from all layer contracts, including submodule contracts. Since VCS plugins (setuptools-scm, hatch-vcs) only auto-generate_version.pyat the package root,a.b._versionshould participate normally in thea.bcontract._versionexclusion in_get_module_layered_architecturewithif "." not in module:, so it only applies to root packagestest_version_not_excluded_in_submoduleverifying_versionstays in layers for subpackage contractsOriginal prompt
_versionis not excluded from Import Linter contracts for submodules #1535⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.