Test that all KeyValueFileManagers support empty files#1467
Merged
nathanjmcdougall merged 2 commits intomainfrom Mar 25, 2026
Merged
Test that all KeyValueFileManagers support empty files#1467nathanjmcdougall merged 2 commits intomainfrom
nathanjmcdougall merged 2 commits intomainfrom
Conversation
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/2248f896-c78b-417b-b5ef-a5379fdd9d5d
Copilot
AI
changed the title
[WIP] Add tests for KeyValueFileManagers to support empty files
Test that all KeyValueFileManagers support empty files
Mar 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
deleted the
copilot/test-keyvaluefilemanagers-empty-files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty files should be valid for all
KeyValueFileManagersubclasses and correspond to an empty map. This is a prerequisite for #241 (lazypyproject.tomlcreation from within config methods).Adds tests for each manager type (
TOMLFileManager,YAMLFileManager,INIFileManager) verifying:read_file()succeeds on an empty file__getitem__([])returns{}__contains__([])returnsTrue__contains__with a nonexistent key returnsFalseAll three parsers already handle empty content correctly — these tests codify that guarantee.
Original prompt
KeyValueFileManagerssupport empty files #905🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.