Skip to content

Add tests for Ruff dev deps not removed when using pre-commit #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 3 commits into from
Mar 22, 2026
Merged

Add tests for Ruff dev deps not removed when using pre-commit #1464

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16ea9fb
Initial plan
Copilot Mar 22, 2026
6eef870
Add tests verifying Ruff dev deps are not removed when using pre-comm…
Copilot Mar 22, 2026
2cfa912
Apply formatter fixes to test file
Copilot Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 74 additions & 4 deletions tests/usethis/_core/test_core_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2074,6 +2074,24 @@ def test_codespell_used(self, uv_init_repo_dir: Path):
dev_deps = get_deps_from_group("dev")
assert any(dep.name == "codespell" for dep in dev_deps)

@pytest.mark.usefixtures("_vary_network_conn")
def test_ruff_used(self, uv_init_repo_dir: Path):
with change_cwd(uv_init_repo_dir), files_manager():
# Arrange
use_ruff()

# Act
use_pre_commit()

# Assert
hook_names = get_hook_ids()
assert "ruff-check" in hook_names
assert "ruff-format" in hook_names

# Issue #1126: Deps should remain even when using pre-commit
dev_deps = get_deps_from_group("dev")
assert any(dep.name == "ruff" for dep in dev_deps)

class TestRemove:
@pytest.mark.usefixtures("_vary_network_conn")
def test_config_file(self, uv_init_repo_dir: Path):
Expand Down Expand Up @@ -2392,6 +2410,52 @@ def test_deps_not_added_when_migrating_from_pre_commit(self, uv_init_dir: Path):
assert len(codespell_deps_after) == 1
assert codespell_deps_after == codespell_deps_before

@pytest.mark.usefixtures("_vary_network_conn")
def test_ruff_deps_not_removed_when_migrating_to_pre_commit(
self, uv_init_dir: Path
):
"""Test that Ruff deps are NOT removed when migrating to pre-commit."""
with change_cwd(uv_init_dir), files_manager():
# Arrange - Add Ruff first
use_ruff()

# Verify dep is present before migration
dev_deps_before = get_deps_from_group("dev")
assert any(dep.name == "ruff" for dep in dev_deps_before)

# Act - Add pre-commit (which triggers migration)
use_pre_commit()

# Assert - Dep should STILL be present after migration (issue #1126)
dev_deps_after = get_deps_from_group("dev")
assert any(dep.name == "ruff" for dep in dev_deps_after)

@pytest.mark.usefixtures("_vary_network_conn")
def test_ruff_deps_not_added_when_migrating_from_pre_commit(
self, uv_init_dir: Path
):
"""Test that Ruff deps are NOT re-added when migrating from pre-commit."""
with change_cwd(uv_init_dir), files_manager():
# Arrange - Add pre-commit first, then Ruff
use_pre_commit()
use_ruff()

# Verify dep is present before removal
dev_deps_before = get_deps_from_group("dev")
ruff_deps_before = [
dep for dep in dev_deps_before if dep.name == "ruff"
]
assert len(ruff_deps_before) == 1

# Act - Remove pre-commit (which triggers migration)
use_pre_commit(remove=True)

# Assert - Dep should still be present exactly once (not duplicated)
dev_deps_after = get_deps_from_group("dev")
ruff_deps_after = [dep for dep in dev_deps_after if dep.name == "ruff"]
assert len(ruff_deps_after) == 1
assert ruff_deps_after == ruff_deps_before


class TestPyprojectFmt:
class TestAdd:
Expand Down Expand Up @@ -3819,9 +3883,12 @@ def test_use_first(self, uv_init_repo_dir: Path):

# Assert
hook_names = get_hook_ids()
assert "ruff-format" in hook_names
assert "ruff-check" in hook_names

assert "ruff-format" in hook_names
assert "ruff-check" in hook_names
# Issue #1126: Deps should remain even when using pre-commit
dev_deps = get_deps_from_group("dev")
assert any(dep.name == "ruff" for dep in dev_deps)

@pytest.mark.usefixtures("_vary_network_conn")
def test_use_after(self, uv_init_repo_dir: Path):
Expand All @@ -3834,9 +3901,12 @@ def test_use_after(self, uv_init_repo_dir: Path):

# Assert
hook_names = get_hook_ids()
assert "ruff-format" in hook_names
assert "ruff-check" in hook_names

assert "ruff-format" in hook_names
assert "ruff-check" in hook_names
# Issue #1126: Deps should be added even when pre-commit is used
dev_deps = get_deps_from_group("dev")
assert any(dep.name == "ruff" for dep in dev_deps)

@pytest.mark.usefixtures("_vary_network_conn")
def test_remove(
Expand Down
Loading