Add tests for Ruff dev deps not removed when using pre-commit#1464
Merged
nathanjmcdougall merged 3 commits intomainfrom Mar 22, 2026
Merged
Add tests for Ruff dev deps not removed when using pre-commit#1464nathanjmcdougall merged 3 commits intomainfrom
nathanjmcdougall merged 3 commits intomainfrom
Conversation
…it (#1126) Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/9b1d5f0b-61a3-46d4-bacf-a1ae0dfc4b50
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com> Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/9b1d5f0b-61a3-46d4-bacf-a1ae0dfc4b50
Copilot
AI
changed the title
[WIP] Fix dev dependencies removal in pre-commit configuration
Add tests for Ruff dev deps not removed when using pre-commit
Mar 22, 2026
nathanjmcdougall
approved these changes
Mar 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code fix to stop removing dev deps during pre-commit migration (commit 3a06c95) only added test coverage for codespell and pyproject-fmt. Ruff was explicitly called out as affected but had no test coverage.
Tests added
TestPreCommit.TestAdd.test_ruff_used— Ruff dev dep persists whenuse_pre_commit()is called afteruse_ruff()TestPreCommit.TestMigration.test_ruff_deps_not_removed_when_migrating_to_pre_commit— Ruff dep survives migration to pre-commitTestPreCommit.TestMigration.test_ruff_deps_not_added_when_migrating_from_pre_commit— Ruff dep not duplicated when removing pre-commitTestRuff.TestPrecommitIntegration.test_use_first/test_use_after— Extended existing hook-only assertions to also verify dev dep presence in both orderingsOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.