Skip to content

Remove import cycles#1436

Merged
nathanjmcdougall merged 1 commit intomainfrom
1311-enable-reportimportcycles-in-basedpyright2
Mar 20, 2026
Merged

Remove import cycles#1436
nathanjmcdougall merged 1 commit intomainfrom
1311-enable-reportimportcycles-in-basedpyright2

Conversation

@nathanjmcdougall
Copy link
Copy Markdown
Collaborator

@nathanjmcdougall nathanjmcdougall commented Mar 20, 2026

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Mar 20, 2026 that may be closed by this pull request
enable reportImportCycles in basedpyright #1311
Closed
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 20, 2026

Merging this PR will not alter performance

✅ 2 untouched benchmarks

Comparing 1311-enable-reportimportcycles-in-basedpyright2 (7b62188) with main (9305f2e)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (85241cc) during the generation of this report, so 9305f2e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@nathanjmcdougall nathanjmcdougall merged commit a540ddd into main Mar 20, 2026
19 checks passed
@nathanjmcdougall nathanjmcdougall deleted the 1311-enable-reportimportcycles-in-basedpyright2 branch March 20, 2026 20:53
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enable reportImportCycles in basedpyright

1 participant

@nathanjmcdougall