Move `config_spec` into `ToolSpec` by Copilot · Pull Request #1430 · usethis-python/usethis-python

Copilot · 2026-03-20T03:32:26Z

config_spec() lived on Tool, forcing is_likely_used() to take a separate ConfigSpec parameter alongside ToolSpec. Moving it to ToolSpec lets is_likely_used work with just a ToolSpec.

Protocol changes

Added config_spec() to ToolSpec (default: ConfigSpec.empty())
Moved get_active_config_file_managers and _get_active_config_file_managers_from_resolution from Tool to ToolSpec
Removed config_spec() from Tool
Simplified is_likely_used(tool_spec: ToolSpec) — dropped the config_spec parameter, now calls tool_spec.config_spec() internally

# Before
def is_likely_used(tool_spec: ToolSpec, config_spec: ConfigSpec) -> bool: ...

# After
def is_likely_used(tool_spec: ToolSpec) -> bool: ...

All implementations moved from `impl/base/` → `impl/spec/`

All config_spec() implementations now live at the spec layer:

Codespell, Coverage.py, Deptry, MkDocs, Pyproject-fmt, Pytest
Ruff — __init__ (with linter_detection / formatter_detection attrs) and config_spec() moved to RuffToolSpec
Import Linter — config_spec() and helpers (_are_active_ini_contracts, _is_root_package_singular) moved to ImportLinterToolSpec

Original prompt

This section details on the original issue you should resolve

<issue_title>Move config_spec into ToolSpec</issue_title>
<issue_description>Toward #1311.

This will also mean we can refactor is_likely_used.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Move config_spec into ToolSpec #1429

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

- Add config_spec() method to ToolSpec protocol in spec.py - Move config_spec() implementations from impl/base/ to impl/spec/ for: codespell, coverage_py, deptry, mkdocs, pyproject_fmt, pytest - Keep config_spec() override on impl/base/ for ruff (uses instance attrs) and import_linter (uses Tool methods) - Refactor is_likely_used() to only take ToolSpec (removed config_spec param) - Update Tool.is_used() to call simplified is_likely_used() - Update tests accordingly Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

codecov · 2026-03-20T11:06:41Z

Codecov Report

❌ Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/usethis/_tool/impl/spec/import_linter.py	97.77%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-03-20T11:06:42Z

Merging this PR will not alter performance

✅ 2 untouched benchmarks

_{Comparing copilot/move-config-spec-into-toolspec (f0b26bf) with main (966a19b)}

nathanjmcdougall · 2026-03-20T11:15:03Z

@copilot you said you did this:

These override config_spec() on the Tool subclass because they depend on Tool-level state:

Ruff — uses self.linter_detection / self.formatter_detection instance attrs
Import Linter — uses Tool._get_active_config_file_managers_from_resolution() via helpers

But I want you to move the init method on RuffTool into RuffToolSpec so these ruff attrs are available at the spec level

And I want you to move get_active_config_file_managers and the helper _get_active_config_file_managers_from_resolution into the ToolSpec class too

- Move RuffTool.__init__ to RuffToolSpec so linter_detection/formatter_detection attrs are available at the spec level - Move config_spec from RuffTool to RuffToolSpec - Move config_spec and helpers (_are_active_ini_contracts, _is_root_package_singular) from ImportLinterTool to ImportLinterToolSpec - Move get_active_config_file_managers and _get_active_config_file_managers_from_resolution from Tool to ToolSpec Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot · 2026-03-20T11:23:48Z

@copilot you said you did this:

These override config_spec() on the Tool subclass because they depend on Tool-level state:
...

Done in b247646:

Moved RuffTool.__init__ → RuffToolSpec.__init__ (so linter_detection/formatter_detection are at the spec level)
Moved config_spec() from RuffTool → RuffToolSpec and from ImportLinterTool → ImportLinterToolSpec (including _are_active_ini_contracts, _is_root_package_singular helpers)
Moved get_active_config_file_managers and _get_active_config_file_managers_from_resolution from Tool → ToolSpec

All config_spec implementations now live in impl/spec/ files. All static checks and tests pass.

Initial plan

73ea9d6

Copilot AI assigned Copilot and nathanjmcdougall Mar 20, 2026

Copilot started work on behalf of nathanjmcdougall March 20, 2026 03:32 View session

Copilot AI and others added 2 commits March 20, 2026 03:44

Apply formatting fixes from static checks

9a580f9

Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Move config_spec into ToolSpec~~ Move config_spec into ToolSpec Mar 20, 2026

Copilot AI requested a review from nathanjmcdougall March 20, 2026 03:47

Copilot finished work on behalf of nathanjmcdougall March 20, 2026 03:47

Copilot AI temporarily deployed to codecov March 20, 2026 11:02 Inactive

Copilot started work on behalf of nathanjmcdougall March 20, 2026 11:15 View session

Copilot finished work on behalf of nathanjmcdougall March 20, 2026 11:25

Copilot AI temporarily deployed to codecov March 20, 2026 18:05 Inactive

Merge branch 'main' into copilot/move-config-spec-into-toolspec

f0b26bf

nathanjmcdougall temporarily deployed to codecov March 20, 2026 18:18 — with GitHub Actions Inactive

nathanjmcdougall marked this pull request as ready for review March 20, 2026 18:18

nathanjmcdougall approved these changes Mar 20, 2026

View reviewed changes

nathanjmcdougall merged commit 2ae04db into main Mar 20, 2026
17 checks passed

nathanjmcdougall deleted the copilot/move-config-spec-into-toolspec branch March 20, 2026 18:18

nathanjmcdougall mentioned this pull request Mar 20, 2026

Add @final to all methods in all ToolSpec and Tool implementations #1431

Closed

Copilot AI mentioned this pull request Mar 20, 2026

Add @final to all methods in ToolSpec and Tool implementations #1432

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move `config_spec` into `ToolSpec`#1430

Move `config_spec` into `ToolSpec`#1430
nathanjmcdougall merged 5 commits intomainfrom
copilot/move-config-spec-into-toolspec

Copilot AI commented Mar 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

nathanjmcdougall commented Mar 20, 2026

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Protocol changes

All implementations moved from impl/base/ → impl/spec/

Comments on the Issue (you are @copilot in this section)

Uh oh!

codecov bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

nathanjmcdougall commented Mar 20, 2026

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Mar 20, 2026 •

edited

Loading

All implementations moved from `impl/base/` → `impl/spec/`

codecov bot commented Mar 20, 2026 •

edited

Loading

codspeed-hq bot commented Mar 20, 2026 •

edited

Loading