Skip to content

Enable reportUnusedParameter in basedpyright#1414

Merged
nathanjmcdougall merged 3 commits intomainfrom
copilot/enable-report-unused-parameter-again
Mar 13, 2026
Merged

Enable reportUnusedParameter in basedpyright#1414
nathanjmcdougall merged 3 commits intomainfrom
copilot/enable-report-unused-parameter-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 13, 2026 •
edited
Loading

reportUnusedParameter was globally suppressed in basedpyright, leaving unused function parameters undetected across the entire codebase.

Changes

  • Enable rule globally: Remove reportUnusedParameter = false from [tool.basedpyright]
  • Suppress in tests: Add reportUnusedParameter = false to the tests execution environment (unused parameters are idiomatic there, e.g. pytest fixtures used for side-effects)
[[tool.basedpyright.executionEnvironments]]
root = "tests"
reportUnreachable = false
reportUnusedFunction = false
reportUnusedParameter = false  # added

The src/ codebase already has zero violations.

Original prompt

This section details on the original issue you should resolve

<issue_title>enable reportUnusedParameter in basedpyright</issue_title>
<issue_description>We should define an execution environment for src versus src/tests where we keep the rule disabled, but I think it makes sense to comply with the rule within the actual codebase itself.

executionEnvironments = [
{ root = "tests", reportUnusedParameter = false},
{ root = "src" }
]

Other violations are from singledispatch.</issue_description>

Comments on the Issue (you are @copilot in this section)

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI and others added 2 commits March 13, 2026 05:05
@nathanjmcdougall
initial plan
cc32439 
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
@nathanjmcdougall
Enable reportUnusedParameter in basedpyright (disable only in tests)
b939588 
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable reportUnusedParameter in basedpyright Enable reportUnusedParameter in basedpyright Mar 13, 2026
Copilot AI requested a review from nathanjmcdougall March 13, 2026 05:07
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review March 13, 2026 05:48
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 13, 2026

Merging this PR will not alter performance

✅ 2 untouched benchmarks

Comparing copilot/enable-report-unused-parameter-again (b939588) with main (1ab80c2)

Open in CodSpeed

@nathanjmcdougall nathanjmcdougall merged commit a2fa80d into main Mar 13, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/enable-report-unused-parameter-again branch March 13, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanjmcdougall nathanjmcdougall nathanjmcdougall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanjmcdougall nathanjmcdougall

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enable reportUnusedParameter in basedpyright

2 participants

@nathanjmcdougall