Skip to content

Enable reportPrivateLocalImportUsage in basedpyright #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 1 commit into from
Feb 23, 2026
Merged

Enable reportPrivateLocalImportUsage in basedpyright #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ reportInvalidAbstractMethod = false
reportMissingParameterType = false
reportMissingTypeArgument = false
reportMissingTypeStubs = false
reportPrivateLocalImportUsage = false
reportPrivateUsage = false
reportUnannotatedClassAttribute = false
reportUnknownArgumentType = false
Expand Down
2 changes: 1 addition & 1 deletion src/usethis/_tool/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@
if TYPE_CHECKING:
from pathlib import Path

from usethis._backend.uv.deps import Dependency
from usethis._integrations.pre_commit import schema as pre_commit_schema
from usethis._io import KeyValueFileManager
from usethis._tool.config import ConfigItem, ResolutionT
from usethis._tool.rule import Rule
from usethis._types.deps import Dependency


class Tool(Protocol):
Expand Down
5 changes: 2 additions & 3 deletions src/usethis/_tool/impl/pyproject_toml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
from usethis._tool.impl.ruff import RuffTool

if TYPE_CHECKING:
from usethis._backend.uv.deps import (
Dependency,
)
from usethis._types.deps import Dependency


OTHER_TOOLS: list[Tool] = [
CodespellTool(),
Expand Down
4 changes: 1 addition & 3 deletions src/usethis/_tool/impl/requirements_txt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
from usethis._types.backend import BackendEnum

if TYPE_CHECKING:
from usethis._backend.uv.deps import (
Dependency,
)
from usethis._types.deps import Dependency


class RequirementsTxtTool(Tool):
Expand Down
3 changes: 2 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@

import pytest

from usethis._backend.uv.call import call_subprocess, call_uv_subprocess
from usethis._backend.uv.call import call_uv_subprocess
from usethis._config import usethis_config
from usethis._console import _cached_warn_print, get_icon_mode
from usethis._file.pyproject_toml.io_ import PyprojectTOMLManager
from usethis._subprocess import call_subprocess
from usethis._test import change_cwd, is_offline
from usethis._tool.impl.import_linter import _importlinter_warn_no_packages_found

Expand Down
2 changes: 1 addition & 1 deletion tests/usethis/_integrations/ci/bitbucket/test_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
from usethis._config_file import files_manager
from usethis._integrations.ci.bitbucket import schema
from usethis._integrations.ci.bitbucket.anchor import ScriptItemAnchor
from usethis._integrations.ci.bitbucket.errors import UnexpectedImportPipelineError
from usethis._integrations.ci.bitbucket.init import (
ensure_bitbucket_pipelines_config_exists,
)
from usethis._integrations.ci.bitbucket.steps import (
_CACHE_LOOKUP,
UnexpectedImportPipelineError,
_add_step_caches_via_model,
add_bitbucket_step_in_default,
add_placeholder_step_in_default,
Expand Down
4 changes: 3 additions & 1 deletion tests/usethis/_integrations/ci/github/test_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import pytest
from requests.exceptions import HTTPError

from usethis._integrations.ci.github.tags import (
from usethis._integrations.ci.github.errors import (
GitHubTagError,
NoGitHubTagsFoundError,
)
from usethis._integrations.ci.github.tags import (
get_github_latest_tag,
)

Expand Down