Ensure test directory ignore rules are only added if the /tests exists#1232
Merged
nathanjmcdougall merged 4 commits intomainfrom Dec 28, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where Ruff test directory ignore rules were being added to pyproject.toml even when the /tests directory doesn't exist in the project. The change adds a conditional check to verify the directory exists before adding test-specific configuration.
Key Changes:
- Added existence check for
tests/directory before applying test-specific Ruff ignore rules - Added test case to verify ignore rules are not added when
tests/directory is missing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/usethis/_tool/impl/ruff.py |
Added conditional check to verify tests/ directory exists before adding test-specific ignore rules |
tests/usethis/_ui/interface/test_tool.py |
Added test case verifying that test directory ignore rules are not added when directory doesn't exist |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #1232 will not alter performanceComparing Summary
|
nathanjmcdougall
deleted the
1041-for-import-linter-dont-add-config-relating-to-disabling-inp-for-the-tests-directory-unless-it-exists
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1041