Implement a get_minimum_pre_commit_version function#1165
Merged
nathanjmcdougall merged 1 commit intomainfrom Nov 22, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #1165 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a get_minimum_pre_commit_version() function that reads the minimum pre-commit version from .pre-commit-config.yaml. The function returns the version as a string (e.g., "4.4.0") or None if the file doesn't exist or the version isn't specified.
Key Changes
- Adds
get_minimum_pre_commit_version()function insrc/usethis/_integrations/pre_commit/version.py - Includes comprehensive test coverage for happy path, missing config, and missing version declaration scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/usethis/_integrations/pre_commit/version.py |
Implements the core function to retrieve minimum pre-commit version from config |
tests/usethis/_integrations/pre_commit/test_version.py |
Adds test coverage for all code paths including edge cases |
nathanjmcdougall
deleted the
1164-a-get_minimum_supported_pre_commit_version-function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.