Skip to content

Allow extra fields in YAML schema modules, add stricter validation #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 12 commits into from
Oct 27, 2025
Merged

Allow extra fields in YAML schema modules, add stricter validation #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a4d14e7
Bump `datamodel-code-generator` from 0.28.2 to 0.35.0
nathanjmcdougall Oct 26, 2025
e2b744e
Allow extra fields in YAML schema modules
nathanjmcdougall Oct 26, 2025
e6b1e3c
Add test module
nathanjmcdougall Oct 26, 2025
1831781
Forbid `StepBase.script` from being None in bitbucket pipelines (i.e.…
nathanjmcdougall Oct 26, 2025
f3e783a
Avoid using `default_factory` in schema modules to preserve round-tri…
nathanjmcdougall Oct 26, 2025
fe97a1d
Use explicit default kwarg for `pydantic.Field` declarations
nathanjmcdougall Oct 26, 2025
e7698a2
Replace defaults with None in schemas for roundtripping
nathanjmcdougall Oct 27, 2025
600bbda
Use `by_alias=True` when using `.model_dump*` pydantic methods
nathanjmcdougall Oct 27, 2025
fa61cb3
Fix typo in comment
nathanjmcdougall Oct 27, 2025
ed247d2
Restore `max-time` alias
nathanjmcdougall Oct 27, 2025
c4f3539
Merge branch '151-how-to-deal-with-out-of-schema-logic' of https://gi…
nathanjmcdougall Oct 27, 2025
cc8eca4
Run ruff formatter
nathanjmcdougall Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ scripts.usethis = "usethis.__main__:app"

[dependency-groups]
dev = [
"datamodel-code-generator[http]>=0.28.2",
"datamodel-code-generator[http]>=0.35.0",
"deptry>=0.23.0",
"import-linter>=2.3",
"jinja2>=3.1.6",
Expand Down
6 changes: 3 additions & 3 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@ coverage==7.7.1 \
--hash=sha256:eff187177d8016ff6addf789dcc421c3db0d014e4946c1cc3fbf697f7852459d \
--hash=sha256:fbba59022e7c20124d2f520842b75904c7b9f16c854233fa46575c69949fb5b9
# via pytest-cov
datamodel-code-generator==0.28.2 \
--hash=sha256:5f16fe4d6acee79c1366f9ee68016eeec544fc0a2fec25ce47d35f7b7767e0fe \
--hash=sha256:a2c425386c3f836c618ae276be57e460df323ac78f911b1b12d927ddffd70e73
datamodel-code-generator==0.35.0 \
--hash=sha256:46805fa2515d3871f6bfafce9aa63128e735a7a6a4cfcbf9c27b3794ee4ea846 \
--hash=sha256:c356d1e4a555f86667a4262db03d4598a30caeda8f51786555fd269c8abb806b
deptry==0.23.0 \
--hash=sha256:04afae204654542406318fd3dd6f4a6697579597f37195437daf84a53ee0ebbf \
--hash=sha256:1cfa4b3a46ee8a026eaa38e4b9ba43fe6036a07fe16bf0a663cb611b939f6af8 \
Expand Down
2 changes: 1 addition & 1 deletion src/usethis/_integrations/ci/bitbucket/pipeweld.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
def get_pipeweld_step(step: Step) -> str:
if step.name is not None:
return step.name
return step.model_dump_json(exclude_defaults=True)
return step.model_dump_json(exclude_defaults=True, by_alias=True)


def get_pipeweld_pipeline_from_default(
Expand Down
Loading